GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-96398: Purge Emscripten code from configure.ac by erlend-aasland · Pull Request #117836 · python/cpython Conversation
|
|
cc. @corona10 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
What about this change? #117819 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
IMO that should remain. We want to filter emcc out in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
But this code is no reason to remain if we purge them no? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
emcc also defines |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Okay, so to filter out emcc, we need emcc :( Would you like to add a comment on that code to annotate that we do not support each according to PEP? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Or to put it another way: to filter out emcc, we need to know how to identify it :)
We already have the switch in L1130. Did you think about a comment in the check that defines |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Alternatively, we can just keep this code; there is not a huge maintenance burden; a solution could be to add a comment above the lines that are proposed to be purged by this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I don't get why this code has to be removed right now. CPython is full of code specific to "unsupported" platforms such as MinGW or OpenBSD. There are CPython users using this build mode: build CPython for the browser. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yes, let's go with my suggestion from #117836 (comment). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
"CPython in the browser" is a top topic with https://pyodide.org/ and https://pyscript.net/ projects. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.