GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96398: Purge Emscripten code from configure.ac by erlend-aasland · Pull Request #117836 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See gh-113632 and python/peps#3612: Emscripten is no longer supported

  • Issue: configure.ac: using $CC to check compiler names may result in erroneous judgements #96398

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-96398: Purge Emscripten code from configure.ac
ad44734
See pythongh-113632 and python/peps#3612: Emscripten is no longer supported
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner April 13, 2024 07:31
@erlend-aasland erlend-aasland added the skip news label Apr 13, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 13, 2024
configure.ac: using $CC to check compiler names may result in erroneous judgements #96398
Closed
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aasland
erlend-aasland enabled auto-merge (squash) April 13, 2024 07:33
@erlend-aasland
erlend-aasland disabled auto-merge April 13, 2024 07:33
@erlend-aasland

erlend-aasland commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author

cc. @corona10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland mentioned this pull request Apr 13, 2024
gh-96398: Improve accuracy of compiler checks in configure.ac #117815
Merged
@corona10

corona10 commented Apr 13, 2024

Copy link
Copy Markdown
Member

What about this change? #117819

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author

What about this change? #117819

IMO that should remain. We want to filter emcc out in ac_cv_cc_name switches.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Apr 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
#if defined(__EMSCRIPTEN__)
  emcc

But this code is no reason to remain if we purge them no?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author
#if defined(__EMSCRIPTEN__)
  emcc

But this code is no reason to remain if we purge them no?

emcc also defines __clang__ and __GNUC__ :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Apr 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Okay, so to filter out emcc, we need emcc :(

Would you like to add a comment on that code to annotate that we do not support each according to PEP?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author

Okay, so to filter out emcc, we need emcc :(

Or to put it another way: to filter out emcc, we need to know how to identify it :)

Would you like to add a comment on that code to annotate that we do not support each according to PEP?

We already have the switch in L1130. Did you think about a comment in the check that defines ac_cv_cc_name?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author

Alternatively, we can just keep this code; there is not a huge maintenance burden; a solution could be to add a comment above the lines that are proposed to be purged by this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Apr 15, 2024

Copy link
Copy Markdown
Member

I don't get why this code has to be removed right now. CPython is full of code specific to "unsupported" platforms such as MinGW or OpenBSD. There are CPython users using this build mode: build CPython for the browser.

pmp-p and erlend-aasland reacted with thumbs up emoji pmp-p and erlend-aasland reacted with heart emoji
All reactions
  • 👍 2 reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Apr 15, 2024

Copy link
Copy Markdown
Contributor Author

I don't get why this code has to be removed right now. CPython is full of code specific to "unsupported" platforms such as MinGW or OpenBSD. There are CPython users using this build mode: build CPython for the browser.

Yes, let's go with my suggestion from #117836 (comment).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland closed this Apr 15, 2024
@erlend-aasland
erlend-aasland deleted the autoconf/really-drop-emscripten branch April 15, 2024 21:21
@vstinner

vstinner commented Apr 16, 2024

Copy link
Copy Markdown
Member

"CPython in the browser" is a top topic with https://pyodide.org/ and https://pyscript.net/ projects.

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @corona10 @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.