GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115775: Add whatsnew entry about __static_attributes__ by iritkatriel · Pull Request #117909 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 15, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use static analysis to assist inlining values and compact object layout. #115775

📚 Documentation preview 📚: https://cpython-previews--117909.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-115775: Add whatnew entry about __static_attributes__
1929797
@iritkatriel iritkatriel added the docs Documentation in the Doc dir label Apr 15, 2024
@bedevere-app bedevere-app Bot added skip news awaiting core review labels Apr 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 15, 2024
Use static analysis to assist inlining values and compact object layout. #115775
Open
@iritkatriel
iritkatriel requested a review from encukou April 15, 2024 18:59
Eclips4
Eclips4 reviewed Apr 15, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @Eclips4
Update 3.13.rst
376d01e 
Co-authored-by: Kirill Podoprigora <[email protected]>
@iritkatriel iritkatriel changed the title gh-115775: Add whatnew entry about __static_attributes__ gh-115775: Add whatsnew entry about __static_attributes__ Apr 15, 2024
@encukou

encukou commented Apr 16, 2024

Copy link
Copy Markdown
Member

Thanks for the description!

I'm not sure what the use case is for adding this as public API. But since it is exposed, I guess it should also be added to the list of special attributes.

(Sorry about the drip-feed of suggestions :( I'm not following the change closely -- I'm just reacting to the effect on projects tested with the latest alpha.)
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 5 commits April 16, 2024 14:52
@iritkatriel
add doc ref
a8ea23d
@iritkatriel
add contributor
2682ce3
@iritkatriel
add ref
f369414
@iritkatriel
add index
27994ff
@iritkatriel
class prefix
a4c1fd0
@iritkatriel
iritkatriel force-pushed the gh-115775 branch from 251398b to a4c1fd0 Compare April 18, 2024 09:34
iritkatriel added 3 commits April 18, 2024 10:35
@iritkatriel
remove wrong one
92a3f48
@iritkatriel
revert unintended
732e9d2
@iritkatriel
class is not right
83675d6
iritkatriel
iritkatriel commented Apr 18, 2024
View reviewed changes
Comment thread Doc/reference/datamodel.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Apr 18, 2024

Copy link
Copy Markdown
Member

AFAIK, the missing definition should be added like this: iritkatriel#57
iritkatriel reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Add to the other list of auto-added class attributes (#57)
eedd5b5
JelleZijlstra
JelleZijlstra reviewed Apr 19, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra reviewed Apr 19, 2024
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @JelleZijlstra
Apply suggestions from code review
275c349 
Co-authored-by: Jelle Zijlstra <[email protected]>
@encukou
encukou merged commit 8a01fd7 into python:main Apr 19, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 19, 2024
@encukou

encukou commented Apr 19, 2024

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon mentioned this pull request May 1, 2024
GH-115775: Use __static_attributes__ to initialize shared keys #118468
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@Eclips4 Eclips4 Eclips4 left review comments
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @encukou @JelleZijlstra @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.