GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-77102: site: try utf-8 and locale encoding when reading .pth file (GH-117802) by methane · Pull Request #117917 · python/cpython

Conversation

@methane

@methane methane commented Apr 16, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 6dc661b)

  • Issue: .pth files cannot contain folders with utf-8 names #77102

📚 Documentation preview 📚: https://cpython-previews--117917.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
[3.12] pythongh-77102: site: try utf-8 and fallback to locale encodin…
8f81901 
…g when reading .pth file (pythonGH-117802)

(cherry picked from commit 6dc661b)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 16, 2024
This was referenced Apr 16, 2024
gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file #117802
Merged
.pth files cannot contain folders with utf-8 names #77102
Closed
@methane
remove versionchanged:: 3.13
5cba1d3
@methane methane changed the title [3.12] gh-77102: site: try utf-8 and fallback to locale encoding when reading .pth file (GH-117802) [3.12] gh-77102: site: try utf-8 and locale encoding when reading .pth file (GH-117802) Apr 16, 2024
vstinner
vstinner approved these changes Apr 16, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, straightforward backport.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 16, 2024
@methane
methane merged commit 2a58923 into python:3.12 Apr 16, 2024
@methane
methane deleted the backport-6dc661b-3.12 branch April 16, 2024 09:51
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 16, 2024
@abravalheri abravalheri mentioned this pull request May 22, 2024
Adopt UTF-8 for .pth files on Python 3.13 pypa/setuptools#4306
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@methane @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.