GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112730: use keyword only argument for colorize by methane · Pull Request #118086 · python/cpython

Conversation

@methane

@methane methane commented Apr 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use color to highlight error locations #112730

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
pythongh-112730: use keyword only argument for colorize
d48bfc3
@methane
methane requested a review from pablogsal April 19, 2024 07:19
@methane
methane requested a review from iritkatriel as a code owner April 19, 2024 07:19
@bedevere-app bedevere-app Bot mentioned this pull request Apr 19, 2024
Use color to highlight error locations #112730
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 19, 2024
@methane methane added the skip news label Apr 19, 2024
@methane

methane commented Apr 19, 2024

Copy link
Copy Markdown
Member Author

sorry if there is a reason to use kwargs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane

methane commented Apr 19, 2024

Copy link
Copy Markdown
Member Author

Maybe, you don't want to expose this option as public API.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane methane closed this Apr 19, 2024
@maxeonyx

maxeonyx commented Oct 17, 2025

Copy link
Copy Markdown

@methane I think this was a good PR? Although changing away from **kwargs back to just a named arg means that this change would break anyone providing invalid args.

And yeah possibly they didn't want to expose it? But why not?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@methane @maxeonyx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.