GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fixes a few small TSAN issues in dictobject by DinoV · Pull Request #118200 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented Apr 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There's a few spots in the dict implementation where we're not using atomics to access or update the dictionary size. This updates those so that we're using relaxed atomics on them.

The dictobject.h case is a little special because we don't have the FT macros available, so it's special cased with an ifdef.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
Fixup TSAN errors for dict
bfc5569
@bedevere-app bedevere-app Bot mentioned this pull request Apr 23, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@DinoV DinoV added skip news topic-free-threading labels Apr 23, 2024
@DinoV
DinoV requested review from colesbury and mpage April 23, 2024 21:35
mpage
mpage reviewed Apr 23, 2024
View reviewed changes
Comment thread Tools/tsan/suppressions_free_threading.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@DinoV
DinoV marked this pull request as ready for review April 23, 2024 23:53
@DinoV
DinoV requested review from markshannon and methane as code owners April 23, 2024 23:53
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 23, 2024
@mpage

mpage commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

LGTM!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DinoV
Fix more dict races:
62d5937 
    Keys need atomic relaxed loads as they can be assigned from another thread
    Entries need atomic release assigns so the values they point to are seen
    Reading managed dict needs acquire so that the memory of a newly created and published dictionary is visible
@colesbury colesbury changed the title [gh-117657] Fixes a few small TSAN issues in dictobject gh-117657: Fixes a few small TSAN issues in dictobject Apr 25, 2024
colesbury
colesbury approved these changes Apr 25, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 25, 2024
@DinoV
DinoV merged commit 5da0280 into python:main Apr 25, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 25, 2024
@DinoV
DinoV deleted the nogil_dict_tsan branch May 31, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage left review comments
@colesbury colesbury colesbury approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DinoV @mpage @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.