GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116749: Disable GIL by default in free-threaded build by colesbury · Pull Request #118295 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Apr 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Switch GIL to disabled by default in free-threaded build so that the free-threaded CIs catch thread-safety issues.

  • Issue: Disable GIL by default in free-threaded build #116749

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
swtaarrs, mpage, network-shark, itamaro, fried, corona10, FeldrinH, rdenadai, yqy2001, edgarrmondragon, and 10 more reacted with rocket emoji corona10, FeldrinH, rdenadai, danielhollas, and olramde reacted with eyes emoji
All reactions
  • 🚀 20 reactions
  • 👀 5 reactions
@colesbury
pythongh-116749: Disable GIL by default in free-threaded build
9fc88f4 
Switch GIL to disabled by default in free-threaded build so that the
free-threaded CIs catch thread-safety issues.
@colesbury colesbury added skip news topic-free-threading labels Apr 25, 2024
@colesbury

colesbury commented Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot nogil
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2024
Disable GIL by default in free-threaded build #116749
Closed
@bedevere-bot

bedevere-bot commented Apr 25, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9fc88f4 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury requested review from DinoV and swtaarrs April 26, 2024 15:04
@colesbury
colesbury marked this pull request as ready for review April 26, 2024 15:04
@colesbury
colesbury requested a review from ericsnowcurrently as a code owner April 26, 2024 15:04
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 26, 2024
SonicField
SonicField approved these changes Apr 26, 2024
View reviewed changes

@SonicField SonicField left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
swtaarrs
swtaarrs reviewed Apr 26, 2024
View reviewed changes
Comment thread Python/initconfig.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
Configure GIL in ceval_gil.c
167b434
DinoV
DinoV approved these changes Apr 26, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 26, 2024
swtaarrs
swtaarrs approved these changes Apr 26, 2024
View reviewed changes

@swtaarrs swtaarrs left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting 😃

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro, olramde, bluss, and danijar reacted with rocket emoji
All reactions
  • 🚀 4 reactions
@colesbury
colesbury merged commit 5a90de0 into python:main Apr 26, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 26, 2024
@colesbury
colesbury deleted the gh-116749-disable-gil branch April 26, 2024 18:22
@colesbury colesbury mentioned this pull request Apr 26, 2024
Disable the GIL by default in free-threaded builds #116329
Closed
@corona10

corona10 commented Apr 26, 2024

Copy link
Copy Markdown
Member

Historical moment!
FeldrinH, itamaro, vitaldmit, olramde, clembou, cychen2021, danijar, dongwook-chan, Venkat2811, and benjamin-kirkbride reacted with hooray emoji
All reactions
  • 🎉 10 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cychen2021

cychen2021 commented Apr 27, 2024

Copy link
Copy Markdown

Cool!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@swtaarrs swtaarrs mentioned this pull request Apr 30, 2024
gh-116322: Add Py_mod_gil module slot #116882
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swtaarrs swtaarrs swtaarrs approved these changes
@DinoV DinoV DinoV approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
+1 more reviewer
@SonicField SonicField SonicField approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@colesbury @bedevere-bot @corona10 @cychen2021 @swtaarrs @DinoV @SonicField
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.