GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36007: Bump minimum sphinx version to 1.8 by asottile · Pull Request #11887 · python/cpython

Conversation

@asottile

@asottile asottile commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue36007

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile
Bump minimum sphinx version to 1.8
7459b0f
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2019
@bedevere-bot bedevere-bot added the awaiting review label Feb 15, 2019
@Mariatta Mariatta added the needs backport to 3.7 label Feb 15, 2019
Mariatta
Mariatta approved these changes Feb 15, 2019
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 15, 2019
@Mariatta Mariatta added the 🤖 automerge label Feb 15, 2019
@miss-islington
miss-islington merged commit a16ab00 into python:master Feb 15, 2019
@miss-islington

miss-islington commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 15, 2019
@miss-islington

miss-islington commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Sorry, @asottile, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a16ab00c0b8e126ab82e7cb5098af3ea32d315ff 3.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington self-assigned this Feb 15, 2019
@asottile
asottile deleted the bump_sphinx_36007 branch February 15, 2019 23:45
@asottile

asottile commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

@Mariatta I don't think this needs / should be backported to 3.7 -- the :skipif: patch wasn't afaict
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta

Mariatta commented Feb 15, 2019

Copy link
Copy Markdown
Member

Ah you're right. Not sure why I thought it needs a backport. In that case, we're done here.
Thanks again!
asottile reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta removed the needs backport to 3.7 label Feb 15, 2019
@AA-Turner AA-Turner mentioned this pull request Oct 19, 2024
Use the latest Sphinx version #125722
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@asottile @miss-islington @Mariatta @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.