GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117657: Fix QSBR race condition (GH-118843) by miss-islington · Pull Request #118905 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

_Py_qsbr_unregister is called when the PyThreadState is already
detached, so the access to tstate->qsbr isn't safe without locking the
shared mutex. Grab the struct _qsbr_shared from the interpreter
instead.
(cherry picked from commit 33d2019)

Co-authored-by: Alex Turner [email protected]

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SonicField @miss-islington
pythongh-117657: Fix QSBR race condition (pythonGH-118843)
97ca83d 
`_Py_qsbr_unregister` is called when the PyThreadState is already
detached, so the access to `tstate->qsbr` isn't safe without locking the
shared mutex. Grab the `struct _qsbr_shared` from the interpreter
instead.
(cherry picked from commit 33d2019)

Co-authored-by: Alex Turner <[email protected]>
@miss-islington
miss-islington requested a review from ericsnowcurrently as a code owner May 10, 2024 14:26
@bedevere-app bedevere-app Bot added the awaiting review label May 10, 2024
This was referenced May 10, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
gh-117657: Fix QSBR race condition #118843
Merged
@bedevere-app bedevere-app Bot added the skip news label May 10, 2024
@colesbury
colesbury enabled auto-merge (squash) May 10, 2024 14:27
@colesbury
colesbury merged commit 0becae3 into python:3.13 May 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 10, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@miss-islington
miss-islington deleted the backport-33d2019-3.13 branch January 2, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @colesbury @SonicField
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.