GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118469: Document sqlite3 PEP-249 constructors by firatv · Pull Request #118975 · python/cpython

Conversation

@firatv

@firatv firatv commented May 12, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
  • Issue: No documentation for sqlite3.Binary #118469

📚 Documentation preview 📚: https://cpython-previews--118975.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
firatv added 3 commits May 12, 2024 16:04
@firatv
pythongh-118469: Add Date, Time and Timestamp constructors.
ef0bc3e
@firatv
pythongh-118469: Add DateFromTicks, TimeFromTicks and `TimestampF…
4c89b2c 
…romTicks` constructors.
@firatv
pythongh-118469: Add Binary constructor.
e73461a
@firatv
firatv requested review from berkerpeksag and erlend-aasland as code owners May 12, 2024 17:57
@ghost

ghost commented May 12, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 12, 2024
No documentation for sqlite3.Binary #118469
Open
@firatv
Merge branch 'main' into issue-GH118469
6c05d8b
kalebers
kalebers approved these changes May 12, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 12, 2024
@erlend-aasland erlend-aasland changed the title gh-118469: Add missing PEP-249 constructors gh-118469: Document sqlite3 PEP-249 constructors May 14, 2024
erlend-aasland
erlend-aasland requested changes May 14, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't think we should expose implementation details; instead, try to (re)use the wording of PEP-249 (or adapt it to fit within the sqlite3 docs).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting core review labels May 14, 2024
@bedevere-app

bedevere-app Bot commented May 14, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Jul 27, 2024
@erlend-aasland

erlend-aasland commented Jul 27, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR! I don't think we should expose implementation details; instead, try to (re)use the wording of PEP-249 (or adapt it to fit within the sqlite3 docs).

No response for more than two months. Applied the pending label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 27, 2024

Copy link
Copy Markdown
Contributor

There is also a competing PR up:

  • gh-118469: Add documentation for sqlite3 PEP-249 constructors #122091
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firatv
Merge branch 'main' into issue-GH118469
974252f
@firatv

firatv commented Jun 26, 2025

Copy link
Copy Markdown
Author

I apologise for not being around for so long. I checked the preview, seems like everything is set. I assume I should close this PR. Thank you all for your time, attention and efforts. Also, sorry again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@firatv firatv closed this Jun 26, 2025
@MEDX000 MEDX000 added this to MEDX-arabic-programme Jun 26, 2025
@github-project-automation github-project-automation Bot moved this to Todo in MEDX-arabic-programme Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland requested changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
+1 more reviewer
@kalebers kalebers kalebers approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir pending The issue will be closed if no feedback is provided skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@firatv @erlend-aasland @kalebers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.