GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-73991: Add `pathlib.Path.rmtree()` by barneygale · Pull Request #119060 · python/cpython

Conversation

barneygale commented May 15, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Add a Path.rmtree() method that removes an entire directory tree, like shutil.rmtree(). The signature of the optional on_error argument matches the Path.walk() argument of the same name, but differs from the onexc and onerror arguments to shutil.rmtree(). Consistency within pathlib is probably more important.

In the private pathlib ABCs, we add an implementation based on walk().

Issue: Support moving across filesystems in pathlib.Path, as shutil.move() does #73991

📚 Documentation preview 📚: https://cpython-previews--119060.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nineteendo reacted with thumbs up emoji

All reactions

👍 1 reaction


          pythonGH-73991: Add pathlib.Path.rmtree()

bbcb1ce

Add a `Path.rmtree()` method that removes an entire directory tree using
`shutil.rmtree()`. The signature of the optional *on_error* argument
matches the `Path.walk()` argument of the same name, but differs from the
*onexc* and *onerror* arguments to `shutil.rmtree()`. Consistency within
pathlib is probably more important.

In the private pathlib ABCs, we add an implementation based on `walk()`.

barneygale added the topic-pathlib label

May 15, 2024

bedevere-app Bot added the awaiting core review label

May 15, 2024

bedevere-app Bot mentioned this pull request

May 15, 2024

Support moving across filesystems in pathlib.Path, as shutil.move() does #73991

Closed

barneygale added 7 commits

May 15, 2024 01:53


          Merge branch 'main' into pythongh-73991-rmtree

94ef5c1


          Use os.walk() and os.fwalk() rather than shutil.rmtree()

62f7eae


          Undo shutil change

4c73a92


          Line up implementations

98fa2e2


          Merge branch 'main' into pythongh-73991-rmtree


          Tests

b504019


          Merge branch 'main' into pythongh-73991-rmtree

bdd1255

barneygale marked this pull request as draft

June 14, 2024 20:09

bedevere-app Bot removed the awaiting core review label

Jun 14, 2024

barneygale added 6 commits

June 18, 2024 22:42


          Merge branch 'main' into pythongh-73991-rmtree

5d2472e


          Merge branch 'main' into pythongh-73991-rmtree

eadbbe6


          Use implementation from shutil

ab7b086


          Fix some Windows tests.

f88fc12


          More Windows test tweaks

5a0fc07


          This is confusing :/

2559e6a

barneygale marked this pull request as ready for review

June 19, 2024 00:42

bedevere-app Bot added the awaiting core review label

Jun 19, 2024

barneygale added 5 commits

June 24, 2024 18:52


          Merge branch 'main' into pythongh-73991-rmtree

5588e1f

WIP

bcff053


          Merge branch 'main' into pythongh-73991-rmtree

be00bfe


          Fix docs

d8c4291


          Minor tweaks

a9c8d4f

barneygale requested a review from zooba

July 3, 2024 03:55

picnixz reviewed

Jul 3, 2024

View reviewed changes

picnixz left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that addition by the way. Here are some nitpicking comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

barneygale and others added 2 commits

July 4, 2024 19:33


          Apply suggestions from code review

4bcc143

Co-authored-by: Bénédikt Tran <[email protected]>


          Address review feedback.

ab0f447


          Merge branch 'main' into pythongh-73991-rmtree

40ed5c8

barneygale enabled auto-merge (squash)

July 20, 2024 17:48

AA-Turner commented Jul 20, 2024

Copy link

Copy Markdown

Member

Docs failure is #122068

barneygale reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into pythongh-73991-rmtree

0cf0180

barneygale merged commit 094375b into python:main

Jul 20, 2024

bedevere-app Bot removed the awaiting core review label

Jul 20, 2024

Reviewers

picnixz

picnixz left review comments

zooba

Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

barneygale commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner commented Jul 20, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

barneygale commented May 15, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.