GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules (GH-9047) by miss-islington · Pull Request #11921 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 18, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix C implementation of pickle.loads to use importlib's locking mechanisms, and thereby avoid using partially-loaded modules.
(cherry picked from commit 4371c0a)

Co-authored-by: tjb900 [email protected]

https://bugs.python.org/issue34572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tjb900 @miss-islington
bpo-34572: change _pickle unpickling to use import rather than retrie…
cf871d5 
…ving from sys.modules (pythonGH-9047)

Fix C implementation of pickle.loads to use importlib's locking mechanisms, and thereby avoid using partially-loaded modules.
(cherry picked from commit 4371c0a)

Co-authored-by: tjb900 <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Feb 18, 2019
bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules #9047
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 18, 2019
@bedevere-bot bedevere-bot added the awaiting review label Feb 18, 2019
@miss-islington

miss-islington commented Feb 18, 2019

Copy link
Copy Markdown
Contributor Author

@tjb900 and @pitrou: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou
pitrou merged commit 3129432 into python:3.7 Feb 18, 2019
@bedevere-bot bedevere-bot removed the awaiting review label Feb 18, 2019
@miss-islington
miss-islington deleted the backport-4371c0a-3.7 branch February 18, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @pitrou @the-knights-who-say-ni @bedevere-bot @tjb900
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.