GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] bpo-23689: Memory leak in Modules/sre_lib.h · Pull Request #11926 · python/cpython

Conversation

@ghost

@ghost ghost commented Feb 19, 2019 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Try to allocate SRE_REPEAT on state's stack.
This solution messes up the code, so I gave up this solution, and closed this PR.

I will try to implement a simple memory pool later.

https://bugs.python.org/issue23689

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
animalize and others added 6 commits January 19, 2019 11:21
Merge pull request #1 from python/master
9206c6c 
1
Merge pull request #3 from python/master
ed20d2f 
1
Merge pull request #4 from python/master
93ff15f 
1
Merge pull request #5 from python/master
4e15c9a 
5
Merge pull request #6 from python/master
ff729b1 
6
@wjssz
stage 1
2d4996b
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 19, 2019
@bedevere-bot bedevere-bot added the awaiting review label Feb 19, 2019
@matrixise

matrixise commented Feb 19, 2019

Copy link
Copy Markdown
Member

You can prefix your PR with WIP: if you don't want that we merge your PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost changed the title bpo-23689: [Don't merge] Memory leak in Modules/sre_lib.h [WIP] bpo-23689: Memory leak in Modules/sre_lib.h Feb 19, 2019
@ghost

ghost commented Feb 19, 2019

Copy link
Copy Markdown
Author

You can prefix your PR with WIP: if you don't want that we merge your PR.

ok, changed the title.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wjssz
pass test_re.py
740f53c
@ghost ghost closed this Feb 23, 2019
@ghost
ghost deleted the alloc_repeat branch March 29, 2022 15:18
@abacabadabacaba abacabadabacaba mannequin mentioned this pull request Jun 15, 2022
Memory leak in Modules/sre_lib.h #67877
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@matrixise @the-knights-who-say-ni @bedevere-bot @wjssz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.