GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-116043: Simplify HACL* build by msprotz · Pull Request #119320 · python/cpython Conversation
|
|
@chris21k can you comment as to whether this solves your issue? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@msprotz Thanks for looking into it and fixing it. However, I can give you detailed but easy instructions to test it on your fixed python installation (you just have to apdapt your path to the python installation containing the PR): First we create a simple python program. Using hashlib or not I think plays no role. However, we take the following one: Then we do the follwing steps: If make runs through without errors and creates the helloworld binary then everthing should be all right. Sorry for the late reply. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Given that this pull request has been open for several months, I kindly request the maintainers consideration in reviewing and merging it. Implementing these changes would be beneficial for developers who rely on a simplified and robust build process. Thank you for your attention. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
My issue here is that I am not familiar with freeze.py, and since the time I submitted this PR, the build system of Python gained another .a file (for Hacl's Blake2), so it sounds like we should fix freeze.py rather than undo the changes to the build system and no longer rely on .a files. Maybe @picnixz or @chris-eibl know about freeze.py? Also pinging @gpshead FYI |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, I am not familiar with freeze.py |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
And me neither :( maybe @vstinner? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm closing this one in favor of #132438 (since this one also has conflicts). Thanks for the initial work though! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.