GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-111389: Add PyHASH_MULTIPLIER constant (GH-119214) by miss-islington · Pull Request #119334 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 21, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit f6da790)

Co-authored-by: Victor Stinner [email protected]

  • Issue: Consider restoring _PyHASH_INF/BITS/MODULUS/IMAG as public #111389

📚 Documentation preview 📚: https://cpython-previews--119334.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
pythongh-111389: Add PyHASH_MULTIPLIER constant (pythonGH-119214)
110109f 
(cherry picked from commit f6da790)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington
miss-islington requested review from gpshead, gvanrossum, markshannon and tiran as code owners May 21, 2024 17:52
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2024
This was referenced May 21, 2024
Consider restoring _PyHASH_INF/BITS/MODULUS/IMAG as public #111389
Closed
gh-111389: Add PyHASH_MULTIPLIER constant #119214
Merged
@vstinner

vstinner commented May 21, 2024

Copy link
Copy Markdown
Member

@Yhg1s : Are you ok to add this late new feature in 3.13? I forgot to add PyHASH_MULTIPLIER in Python 3.13 when other constants were added to the C API: https://docs.python.org/dev/c-api/hash.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Jun 4, 2024

Copy link
Copy Markdown
Member

Yeah, this is fine to add at this stage.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Jun 4, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 4, 2024
@vstinner
vstinner merged commit 1177897 into python:3.13 Jun 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 4, 2024
@vstinner

vstinner commented Jun 4, 2024

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington deleted the backport-f6da790-3.13 branch January 2, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.