GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-118507 : Fix `ntpath.isfile` for pipes. by nineteendo · Pull Request #119381 · python/cpython

Conversation

@nineteendo

@nineteendo nineteendo commented May 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Refactor nt._path_is* & nt._path_[l]exists #118507

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nineteendo
pythongh-118507 : Refactor nt._path_is* to improve applicability fo…
2fb9812 
…r other cases (pythonGH-118755)
This was referenced May 22, 2024
Refactor nt._path_is* & nt._path_[l]exists #118507
Closed
gh-118507 : Refactor nt._path_is* #118755
Merged
@nineteendo

nineteendo commented May 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I think I didn't include unrelated changes. Is it fine to use the C version for ntpath.isjunction() and ntpath.lexists()? (We did so for 3.13 too) Otherwise I'll revert that change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo
Fix generated files
dddaf35
@nineteendo
nineteendo marked this pull request as ready for review May 22, 2024 07:23
@bedevere-app bedevere-app Bot added the awaiting review label May 22, 2024
@nineteendo nineteendo changed the title [3.12] gh-118507 : Refactor nt._path_is* (GH-118755) [3.12] gh-118507 : Refactor nt._path_is* to improve applicability for other cases (GH-118755) May 22, 2024
@zooba

zooba commented May 22, 2024

Copy link
Copy Markdown
Member

Is it fine to use the C version for ntpath.isjunction() and ntpath.lexists()?

Let's revert those, just to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba self-assigned this May 22, 2024
nineteendo and others added 3 commits May 22, 2024 15:48
@nineteendo
Revert ntpath.isjunction() & ntpath.lexists()
59dbe4f
@nineteendo
Delete Misc/NEWS.d/next/Core and Builtins/2024-05-08-18-33-07.gh-issu…
5c1fe4b 
…e-118507.OCQsAY.rst
@blurb-it
📜🤖 Added by blurb_it.
88ed53c
@nineteendo

nineteendo commented May 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Done, I also removed the C implementation for these functions to not give anyone ideas...
I can make a draft pull request afterwards to make it clear the issue can't be closed yet.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo nineteendo changed the title [3.12] gh-118507 : Refactor nt._path_is* to improve applicability for other cases (GH-118755) [3.12] gh-118507 : Fix ntpath.isfile for pipes. May 22, 2024
@zooba
zooba merged commit 874a4f7 into python:3.12 May 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 22, 2024
@zooba

zooba commented May 22, 2024

Copy link
Copy Markdown
Member

A draft pull request is a good idea.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo
nineteendo deleted the backport-b641825-3.12 branch May 22, 2024 15:01
@nineteendo nineteendo mentioned this pull request Oct 3, 2024
gh-124917: Allow keyword args to os.path.exists/lexists on Windows #124918
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nineteendo @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.