GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-118507 : Speed up `ntpath.isjunction()` & `ntpath.lexists()` with native helpers (GH-118755) by nineteendo · Pull Request #119420 · python/cpython

Conversation

@nineteendo

@nineteendo nineteendo commented May 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Refactor nt._path_is* & nt._path_[l]exists #118507

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nineteendo
Speedup os.path.isjunction and os.path.lexists on Windows with a …
ecf8d3f 
…native implementation.
This was referenced May 22, 2024
Refactor nt._path_is* & nt._path_[l]exists #118507
Closed
gh-118507 : Refactor nt._path_is* #118755
Merged
@nineteendo

nineteendo commented May 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@zooba, add "DO-NOT-MERGE" until we're more confident?
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba added the DO-NOT-MERGE label May 22, 2024
@nineteendo nineteendo changed the title [3.12] gh-118507 : Refactor nt._path_is* to improve applicability for other cases (GH-118755) [3.12] gh-118507 : Speed up ntpath.isjunction() & ntpath.lexists() with native helpers (GH-118755) May 27, 2024
@nineteendo
Rename 2024-05-08-18-33-07.gh-issue-118507.OCQsAY.rst to 2024-05-08-1…
b5319e1 
…8-33-07.gh-issue-118507.OCQsAY.rst
@hugovk

hugovk commented Aug 9, 2024

Copy link
Copy Markdown
Member

Triage: closing because the parent issue has since been closed, and there's been no more discussion since this was opened. Please let me know if it should stay open.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk closed this Aug 9, 2024
@zooba zooba reopened this Aug 9, 2024
@zooba

zooba commented Aug 9, 2024

Copy link
Copy Markdown
Member

Was going to say we should take it now that 3.13.0rc1 has gone out without issue, but I don't actually want to run afoul of the people who say not to put perf improvements into 3.12. So let's just leave it.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba closed this Aug 9, 2024
@nineteendo
nineteendo deleted the backport-b641825-3.12-part2 branch August 9, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nineteendo @hugovk @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.