GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-118727: Don't drop the GIL in `drop_gil()` unless the current thread holds it (GH-118745) by miss-islington · Pull Request #119474 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

drop_gil() assumes that its caller is attached, which means that the current
thread holds the GIL if and only if the GIL is enabled, and the enabled-state
of the GIL won't change. This isn't true, though, because detach_thread()
calls _PyEval_ReleaseLock() after detaching and
_PyThreadState_DeleteCurrent() calls it after removing the current thread
from consideration for stop-the-world requests (effectively detaching it).

Fix this by remembering whether or not a thread acquired the GIL when it last
attached, in PyThreadState._status.holds_gil, and check this in drop_gil()
instead of gil->enabled.

This fixes a crash in test_multiprocessing_pool_circular_import(), so I've
reenabled it.
(cherry picked from commit be1dfcc)

Co-authored-by: Brett Simmers [email protected]

  • Issue: Crash in PyThreadState_DeleteCurrent: drop_gil: GIL is not locked (free-threading) #118727

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@swtaarrs @miss-islington
pythongh-118727: Don't drop the GIL in drop_gil() unless the curren…
e53ddcf
…t thread holds it (pythonGH-118745)

`drop_gil()` assumes that its caller is attached, which means that the current
thread holds the GIL if and only if the GIL is enabled, and the enabled-state
of the GIL won't change. This isn't true, though, because `detach_thread()`
calls `_PyEval_ReleaseLock()` after detaching and
`_PyThreadState_DeleteCurrent()` calls it after removing the current thread
from consideration for stop-the-world requests (effectively detaching it).

Fix this by remembering whether or not a thread acquired the GIL when it last
attached, in `PyThreadState._status.holds_gil`, and check this in `drop_gil()`
instead of `gil->enabled`.

This fixes a crash in `test_multiprocessing_pool_circular_import()`, so I've
reenabled it.
(cherry picked from commit be1dfcc)

Co-authored-by: Brett Simmers <[email protected]>
@miss-islington
miss-islington requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners May 23, 2024 20:59
@bedevere-app bedevere-app Bot added the awaiting review label May 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 23, 2024
Crash in PyThreadState_DeleteCurrent: drop_gil: GIL is not locked (free-threading) #118727
Closed
@bedevere-app bedevere-app Bot added the skip news label May 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 23, 2024
gh-118727: Don't drop the GIL in drop_gil() unless the current thread holds it #118745
Merged
@colesbury
colesbury enabled auto-merge (squash) May 23, 2024 21:00
@colesbury
colesbury merged commit d98d6b1 into python:3.13 May 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 23, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@miss-islington
miss-islington deleted the backport-be1dfcc-3.13 branch January 2, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @colesbury @swtaarrs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.