GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-119496: accept UTF-8 BOM in .pth files (GH-119503) by miss-islington · Pull Request #119508 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Out-File -Encoding utf8 and similar commands in Windows Powershell 5.1 emit
UTF-8 with a BOM marker, which the regular utf-8 codec decodes incorrectly.

utf-8-sig accepts a BOM, but also works correctly without one.

This change also makes .pth files match the way Python source files are handled.

(cherry picked from commit bf5b646)

Co-authored-by: Alyssa Coghlan [email protected]
Co-authored-by: Inada Naoki [email protected]

  • Issue: Improve handling of UTF-16-LE encoded .pth files  #119496

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ncoghlan @methane @miss-islington
pythonGH-119496: accept UTF-8 BOM in .pth files (pythonGH-119503)
6d63eed
`Out-File -Encoding utf8` and similar commands in Windows Powershell 5.1 emit
UTF-8 with a BOM marker, which the regular `utf-8` codec decodes incorrectly.

`utf-8-sig` accepts a BOM, but also works correctly without one.

This change also makes .pth files match the way Python source files are handled.

(cherry picked from commit bf5b646)

Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Inada Naoki <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label May 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 24, 2024
Improve handling of UTF-16-LE encoded .pth files #119496
Open
@bedevere-app bedevere-app Bot added the skip news label May 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 24, 2024
GH-119496: accept UTF-8 BOM in .pth files #119503
Merged
@ncoghlan
ncoghlan enabled auto-merge (squash) May 24, 2024 14:37
@ncoghlan
ncoghlan merged commit 217d57f into python:3.13 May 24, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 24, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@miss-islington
miss-islington deleted the backport-bf5b646-3.13 branch January 2, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @ncoghlan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.