GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-118263: Add additional arguments to path_t (Argument Clinic type) in posixmodule (GH-118355) by nineteendo · Pull Request #119608 · python/cpython

Conversation

@nineteendo

@nineteendo nineteendo commented May 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Generalize path_t for C level optimizations #118263

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nineteendo
pythongh-118263: Add additional arguments to path_t (Argument Clinic …
a7f3e06 
…type) in posixmodule (pythonGH-118355)
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2024
Generalize path_t for C level optimizations #118263
Closed
@nineteendo nineteendo changed the title gh-118263: Add additional arguments to path_t (Argument Clinic type) in posixmodule (GH-118355) [3.12] gh-118263: Add additional arguments to path_t (Argument Clinic type) in posixmodule (GH-118355) May 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2024
gh-118263: Generalize path_t for C level optimizations #118355
Merged
@blurb-it
📜🤖 Added by blurb_it.
803077f
@nineteendo

nineteendo commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@zooba does this also need "DO-NOT-MERGE"? In theory this just removes the Python wrapper.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented May 28, 2024

Copy link
Copy Markdown
Member

As long as it's a draft, it can't be merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo
nineteendo marked this pull request as ready for review May 28, 2024 09:54
@bedevere-app bedevere-app Bot added the awaiting review label May 28, 2024
@nineteendo

nineteendo commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

I marked it as ready for review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 09a85ea into python:3.12 May 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label May 28, 2024
@zooba

zooba commented May 28, 2024

Copy link
Copy Markdown
Member

Let's have it. It looks clean enough, and it'll make backports easier if we change anything around here later on.
nineteendo reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo
nineteendo deleted the backport-96b392d-3.12 branch May 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nineteendo @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.