GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-119118: Fix performance regression in tokenize module (GH-119615) by miss-islington · Pull Request #119682 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 28, 2024

Copy link
Copy Markdown
Contributor
  • tokenize.generate_tokens() performance regression in 3.12 #119118: Fix performance regression in tokenize module
  • Cache line object to avoid creating a Unicode object
    for all of the tokens in the same line.
  • Speed up byte offset to column offset conversion by using the
    smallest buffer possible to measure the difference.

(cherry picked from commit d87b015)

Co-authored-by: Lysandros Nikolaou [email protected]
Co-authored-by: Pablo Galindo [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou @pablogsal @miss-islington
pythongh-119118: Fix performance regression in tokenize module (pytho…
64be1b7 
…nGH-119615)

* pythongh-119118: Fix performance regression in tokenize module

- Cache line object to avoid creating a Unicode object
  for all of the tokens in the same line.
- Speed up byte offset to column offset conversion by using the
  smallest buffer possible to measure the difference.

(cherry picked from commit d87b015)

Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Pablo Galindo <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners May 28, 2024 19:17
@bedevere-app bedevere-app Bot added the awaiting review label May 28, 2024
This was referenced May 28, 2024
tokenize.generate_tokens() performance regression in 3.12 #119118
Closed
gh-119118: Fix performance regression in tokenize module #119615
Merged
lysnikolaou
lysnikolaou approved these changes May 28, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 28, 2024
@lysnikolaou
lysnikolaou merged commit 0d0be6b into python:3.13 May 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 28, 2024
@miss-islington
miss-islington deleted the backport-d87b015-3.13 branch January 2, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.