GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees (GH-119634) by barneygale · Pull Request #119749 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented May 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Make shutil._rmtree_unsafe() call os.walk(), which is implemented
without recursion.

shutil._rmtree_safe_fd() is not affected and can still raise a recursion
error.

Co-authored-by: Jelle Zijlstra [email protected].

(cherry picked from commit a150679)

  • Issue: Change shutil.rmtree and os.walk to support very deep hierarchies #89727

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
barneygale and others added 2 commits May 29, 2024 21:20
@barneygale @JelleZijlstra
pythonGH-89727: Partially fix shutil.rmtree() recursion error on de…
3b03217 
…ep trees (python#119634)

Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented
without recursion.

`shutil._rmtree_safe_fd()` is not affected and can still raise a recursion
error.

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit a150679)
@barneygale
[3.12] pythonGH-89727: Partially fix shutil.rmtree() recursion erro…
4ec8d54 
…r on deep trees (pythonGH-119634)

Make `shutil._rmtree_unsafe()` call `os.walk()`, which is implemented
without recursion.

`shutil._rmtree_safe_fd()` is not affected and can still raise a recursion
error.

Co-authored-by: Jelle Zijlstra <[email protected]>.
(cherry picked from commit a150679)

Co-authored-by: Barney Gale <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label May 29, 2024
This was referenced May 29, 2024
Change shutil.rmtree and os.walk to support very deep hierarchies #89727
Open
GH-89727: Partially fix shutil.rmtree() recursion error on deep trees #119634
Merged
@barneygale
barneygale merged commit 45587df into python:3.12 May 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.