GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-109218: Refactor tests for the complex() constructor (GH-119635) by miss-islington · Pull Request #119795 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Share common classes.
  • Use exactly representable floats and exact tests.
  • Check the sign of zero components.
  • Remove duplicated tests (mostly left after merging int and long).
  • Reorder tests in more consistent way.
  • Test more error messages.
  • Add tests for missed cases.
    (cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: Invalid "equivalents" of the complex type constructor in docs #109218

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-109218: Refactor tests for the complex() constructor (python…
354f797 
…GH-119635)

* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels May 30, 2024
This was referenced May 30, 2024
Invalid "equivalents" of the complex type constructor in docs #109218
Closed
gh-109218: Refactor tests for the complex() constructor #119635
Merged
@bedevere-app bedevere-app Bot added the skip news label May 30, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 30, 2024 17:40
@serhiy-storchaka
Merge branch '3.13' into backport-bf098d4-3.13
660faee
@hugovk
hugovk disabled auto-merge August 9, 2024 14:04
@hugovk
Merge branch '3.13' into backport-bf098d4-3.13
580db1a
@hugovk

hugovk commented Aug 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@serhiy-storchaka You enabled auto-merge on this, but for some reason the "Tests / Windows (free-threading) / build (arm64)" CI failed, so it didn't merge.

Unfortunately the logs have since expired, maybe it was just a temporary thing. I've merged in main to restart the CI.

I've also disabled auto-merge, because 3.13 is in the RC phase and I'll let you make a fresh decision whether it can be merged now.
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Aug 9, 2024

Copy link
Copy Markdown
Member

CI passed now. I think it probably could go into 3.13, it's only changing test files.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit 013752c into python:3.13 Aug 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 9, 2024
@serhiy-storchaka

serhiy-storchaka commented Aug 9, 2024

Copy link
Copy Markdown
Member

Thank you @hugovk for noticing this.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington deleted the backport-bf098d4-3.13 branch January 2, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @hugovk @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.