GeezerVison is showing github.com — [3.12] gh-109218: Refactor tests for the complex() constructor (GH-119635) by miss-islington · Pull Request #119796 · python/cpython
Conversation
miss-islington
commented
May 30, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
- Share common classes.
- Use exactly representable floats and exact tests.
- Check the sign of zero components.
- Remove duplicated tests (mostly left after merging int and long).
- Reorder tests in more consistent way.
- Test more error messages.
- Add tests for missed cases.
(cherry picked from commit bf098d4)
Co-authored-by: Serhiy Storchaka [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…GH-119635)
* Share common classes.
* Use exactly representable floats and exact tests.
* Check the sign of zero components.
* Remove duplicated tests (mostly left after merging int and long).
* Reorder tests in more consistent way.
* Test more error messages.
* Add tests for missed cases.
(cherry picked from commit bf098d4)
Co-authored-by: Serhiy Storchaka <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.