GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-111201: Skip pyrepl Windows tests earlier (#119848) by vstinner · Pull Request #119924 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 1, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't attempt to load pyrepl Windows console if platforms others than Windows. For example, the import can fail if ctypes is missing.

(cherry picked from commit 91601a5)

  • Issue: A new Python REPL #111201

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111201: Skip pyrepl Windows tests earlier (python#119848)
8806c0c 
Don't attempt to load pyrepl Windows console if platforms others than
Windows. For example, the import can fail if ctypes is missing.

(cherry picked from commit 91601a5)
@bedevere-app bedevere-app Bot added skip news tests Tests in the Lib/test dir labels Jun 1, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 1, 2024
gh-111201: Skip pyrepl Windows tests earlier #119848
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 1, 2024
@vstinner
vstinner enabled auto-merge (squash) June 1, 2024 20:59
@bedevere-app bedevere-app Bot mentioned this pull request Jun 1, 2024
A new Python REPL #111201
Closed
7 tasks done
@vstinner
vstinner merged commit ac35d96 into python:3.13 Jun 1, 2024
@vstinner
vstinner deleted the pyrepl313 branch June 1, 2024 21:21
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.