GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117657: Fix race involving immortalizing objects (GH-119927) by colesbury · Pull Request #120005 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Jun 3, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The free-threaded build currently immortalizes objects that use deferred reference counting (see gh-117783). This typically happens once the first non-main thread is created, but the behavior can be suppressed for tests, in subinterpreters, or during a compile() call.

This fixes a race condition involving the tracking of whether the behavior is suppressed.

(cherry picked from commit 47fb432)

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@colesbury
pythongh-117657: Fix race involving immortalizing objects (python#119927
f4e012c
)

The free-threaded build currently immortalizes objects that use deferred
reference counting (see pythongh-117783). This typically happens once the
first non-main thread is created, but the behavior can be suppressed for
tests, in subinterpreters, or during a compile() call.

This fixes a race condition involving the tracking of whether the
behavior is suppressed.

(cherry picked from commit 47fb432)
@colesbury
colesbury requested review from ericsnowcurrently and markshannon as code owners June 3, 2024 22:00
@bedevere-app bedevere-app Bot mentioned this pull request Jun 3, 2024
gh-117657: Fix race involving immortalizing objects #119927
Merged
@bedevere-app bedevere-app Bot added skip news awaiting core review labels Jun 3, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 3, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@colesbury
colesbury enabled auto-merge (squash) June 3, 2024 22:01
@colesbury
colesbury merged commit ae70531 into python:3.13 Jun 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 3, 2024
@colesbury
colesbury deleted the backport-47fb432-3.13 branch June 3, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.