GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120176: Reduce number of compares in index range checks by lgeiger · Pull Request #120181 · python/cpython

Conversation

@lgeiger

@lgeiger lgeiger commented Jun 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR is a followup to #9784 (discussed in #72583 and #67741) and extracts the helper function into internal/pycore_abstract.h and uses it where applicable to reduce the number of comparisons in index range checks.

See https://godbolt.org/z/jM8oexT1d for an assembly comparison.

I feel like this change doesn't reduce readability but let me know if such micro optimisation does not justify the code churn.

  • Issue: Use shared helper function for faster index range checks #120176

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lgeiger
Reduce number of compares in index range checks
6d3e970
@lgeiger
lgeiger requested review from markshannon and methane as code owners June 6, 2024 22:32
@ghost

ghost commented Jun 6, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 6, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
lgeiger reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jun 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 6, 2024
Use shared helper function for faster index range checks #120176
Closed
@methane methane added the skip news label Jun 8, 2024
@methane

methane commented Jun 8, 2024

Copy link
Copy Markdown
Member

No news entry is required because this change is not visible to users.
I assume performance gain is not large enough to have news entry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane
methane approved these changes Jun 8, 2024
View reviewed changes

@methane methane left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I will wait a week before merging this PR to ensure that other committers have the opportunity to review it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 8, 2024
@eendebakpt

eendebakpt commented Jun 8, 2024

Copy link
Copy Markdown
Contributor

@lgeiger @methane This pr is nearly identical to #99762. There are some more review comments there
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Jun 8, 2024

Copy link
Copy Markdown
Member

This idea was already discussed and rejected. See #72583.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Jun 8, 2024
@lgeiger

lgeiger commented Jun 8, 2024

Copy link
Copy Markdown
Contributor Author

Ah sorry, didn't see #99762

Sorry about that!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lgeiger
lgeiger deleted the faster-index-checks branch June 8, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lgeiger @methane @eendebakpt @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.