GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: Fix annotations lookup on classes with custom metaclasses by JelleZijlstra · Pull Request #120719 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jun 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See https://discuss.python.org/t/pep-749-implementing-pep-649/54974/28 and subsequent posts.

  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-119180: Fix annotations lookup on classes with custom metacl…
6f71f30 
…asses

See https://discuss.python.org/t/pep-749-implementing-pep-649/54974/28 and subsequent posts.
@JelleZijlstra
JelleZijlstra requested a review from markshannon as a code owner June 19, 2024 02:35
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2024
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 19, 2024
@JelleZijlstra
JelleZijlstra marked this pull request as draft June 19, 2024 04:42
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 19, 2024
JelleZijlstra added 2 commits June 19, 2024 07:20
@JelleZijlstra
basic annotations descriptor
e468ce7
@JelleZijlstra
Expand prototype
dfcb071
@JelleZijlstra JelleZijlstra mentioned this pull request Jun 19, 2024
PEP 749: Add section on metaclasses python/peps#3847
Merged
JelleZijlstra added 8 commits June 20, 2024 07:37
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep649-meta
1f1ec57
@JelleZijlstra
add get/set
c0a2668
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep649-meta
7f9d3ee
@JelleZijlstra
no more __annotations_cache__
20fb144
@JelleZijlstra
Don't add __set__
832f6f3
@JelleZijlstra
fix leak
1d3abff
@JelleZijlstra
fix test_descr
9969e99
@JelleZijlstra
fix tests
b845c0e
@JelleZijlstra JelleZijlstra mentioned this pull request Jun 21, 2024
gh-119180: Alternative approach to metaclass annotations: never use the dict #120816
Closed
@JelleZijlstra
fix smelly
73eb018
@JelleZijlstra JelleZijlstra mentioned this pull request Jul 21, 2024
gh-119180: Use type descriptors to access annotations (PEP 749) #122074
Merged
@JelleZijlstra

JelleZijlstra commented Jul 23, 2024

Copy link
Copy Markdown
Member Author

We'll go with #122074.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.