GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-120097: Make FrameLocalsProxy a mapping (GH-120101) by miss-islington · Pull Request #120749 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Register FrameLocalsProxy as a subclass of collections.abc.Mapping

  • Allow FrameLocalsProxy to matching mapping patterns
    (cherry picked from commit d1c673b)

Co-authored-by: Mark Shannon [email protected]

  • Issue: FrameLocalsProxy is not a mapping #120097

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@markshannon @miss-islington
pythonGH-120097: Make FrameLocalsProxy a mapping (pythonGH-120101)
7b1502e
* Register FrameLocalsProxy as a subclass of collections.abc.Mapping

* Allow FrameLocalsProxy to matching mapping patterns
(cherry picked from commit d1c673b)

Co-authored-by: Mark Shannon <[email protected]>
@miss-islington
miss-islington requested review from markshannon and rhettinger as code owners June 19, 2024 17:03
This was referenced Jun 19, 2024
FrameLocalsProxy is not a mapping #120097
Closed
GH-120097: Make FrameLocalsProxy a mapping #120101
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 19, 2024
@rhettinger
rhettinger removed their request for review June 19, 2024 17:55
@ncoghlan
Merge branch '3.13' into backport-d1c673b-3.13
ec822b1
ncoghlan
ncoghlan approved these changes Aug 1, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 1, 2024
@gpshead gpshead assigned Yhg1s Aug 9, 2024
@markshannon
Merge branch '3.13' into backport-d1c673b-3.13
267d053
@markshannon
markshannon merged commit 95b4f9c into python:3.13 Aug 23, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 23, 2024
@miss-islington
miss-islington deleted the backport-d1c673b-3.13 branch January 2, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ncoghlan @Yhg1s @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.