GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120838: Add Tests For "Bad" Usage in Runtime Lifecycle Operations by ericsnowcurrently · Pull Request #120840 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We also report the various bad usage cases to stderr.

  • Issue: Some Runtime Finalization Constraints Are Not Enforced Nor Documented #120838

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 4 commits June 20, 2024 15:03
@ericsnowcurrently
Add the option to not reuse the initial tstate.
4e8a976
@ericsnowcurrently
Add a test to verify the initial "main" tstate isn't special.
120c2a6
@ericsnowcurrently
Add tests to check different "bad" runtime fini situations.
608139b
@ericsnowcurrently
Fix the code in test_audit_subinterpreter.
592b214
@ericsnowcurrently ericsnowcurrently added the skip news label Jun 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 21, 2024
Some Runtime Finalization Constraints Are Not Enforced Nor Documented #120838
Open
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 21, 2024
@ericsnowcurrently
Always try reusing the main tstate (and drop interp.reuse_init_tstate).
e6f31ff
@ericsnowcurrently

ericsnowcurrently commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

@ncoghlan, @vstinner, any thoughts on these tests?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 3 commits June 25, 2024 11:35
@ericsnowcurrently
Skip test_fini_in_subthread on Windows.
05c0cf3
@ericsnowcurrently
Expect a failure on Windows.
8b241d2
@ericsnowcurrently
Fail if PyFinalize() fails.
b66c2b7
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 25, 2024
@bedevere-bot

bedevere-bot commented Jun 25, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit b66c2b7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 25, 2024
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.13 only security fixes label Jun 25, 2024
ericsnowcurrently added 8 commits June 25, 2024 12:20
@ericsnowcurrently
Add _Py_Finalize() and struct pyfinalize_args.
88b1679
@ericsnowcurrently
Use _Py_Finalize() in the new tests.
d9d0e10
@ericsnowcurrently
Factor out resolve_final_tstate().
72e961f
@ericsnowcurrently
Fix the Windows returncode.
e2392c2
@ericsnowcurrently
Export _Py_Finalize().
6b1eb57
@ericsnowcurrently
Do not print the error messages with Py_Exit().
7b2afb6
@ericsnowcurrently
Rename the macro.
155dddc
@ericsnowcurrently
Fix the macro.
f37bcc7
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) June 25, 2024 20:06
@ericsnowcurrently
ericsnowcurrently disabled auto-merge June 25, 2024 20:06
@ericsnowcurrently ericsnowcurrently removed the needs backport to 3.13 only security fixes label Jun 25, 2024
ericsnowcurrently added 3 commits June 26, 2024 15:36
@ericsnowcurrently
Merge branch 'main' into tests-runtime-lifecycle-bad-usage
0cffd32
@ericsnowcurrently
Fix tests.
361d477
@ericsnowcurrently
Tweaks to resolve_final_tstate().
d3beea4
@ericsnowcurrently
Fix the test failures.
d78f655
@ericsnowcurrently
ericsnowcurrently force-pushed the tests-runtime-lifecycle-bad-usage branch from 232d35a to fe12f40 Compare June 27, 2024 20:40
@ericsnowcurrently
More tweaking resolve_final_tstate().
e5c5a5f
@ericsnowcurrently
ericsnowcurrently force-pushed the tests-runtime-lifecycle-bad-usage branch from fe12f40 to e5c5a5f Compare June 27, 2024 20:42
@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.