GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-104855: Update Tkinter tests for Tcl/Tk 8.7 and 9.0 (GH-120824) by miss-islington · Pull Request #120864 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 22, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The tests are now passed with the current version of Tcl/Tk under
development (8.7b1+ and 9.0b3+).

The following changes were also made to make the tests more flexible:

  • Helper methods like checkParam() now interpret the expected error message
    as a regular expression instead of a literal.
  • Add support of new arguments in checkEnumParam():
    • allow_empty=True skips testing with empty string;
    • fullname= specifies the name for error message if it differs from the
      option name;
    • sort=True sorts values for error message.
  • Add support of the allow_empty argument in checkReliefParam():
    allow_empty=True adds an empty string to the list of accepted values.
  • Attributes _clip_highlightthickness, _clip_pad and _clip_borderwidth
    specify how negative values of options -highlightthickness, -padx, -pady
    and -borderwidth are handled.
  • Use global variables for some common error messages.

(cherry picked from commit 6ad26de)

Co-authored-by: Serhiy Storchaka [email protected]
Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: Certain Tkinter tests fail on Tk 8.7 due to TIP 577 #104855

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @terryjreedy @miss-islington
pythongh-104855: Update Tkinter tests for Tcl/Tk 8.7 and 9.0 (pythonG…
c94ecb7
…H-120824)

The tests are now passed with the current version of Tcl/Tk under
development (8.7b1+ and 9.0b3+).

The following changes were also made to make the tests more flexible:

* Helper methods like checkParam() now interpret the expected error message
  as a regular expression instead of a literal.
* Add support of new arguments in checkEnumParam():
  - allow_empty=True skips testing with empty string;
  - fullname= specifies the name for error message if it differs from the
    option name;
  - sort=True sorts values for error message.
* Add support of the allow_empty argument in checkReliefParam():
  allow_empty=True adds an empty string to the list of accepted values.
* Attributes _clip_highlightthickness, _clip_pad and  _clip_borderwidth
  specify how negative values of options -highlightthickness, -padx, -pady
  and -borderwidth are handled.
* Use global variables for some common error messages.

(cherry picked from commit 6ad26de)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Jun 22, 2024
Certain Tkinter tests fail on Tk 8.7 due to TIP 577 #104855
Closed
@bedevere-app bedevere-app Bot added the skip news label Jun 22, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jun 22, 2024
gh-104855: Update Tkinter tests for Tcl/Tk 8.7 and 9.0 #120824
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jun 22, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) June 22, 2024 06:54
@serhiy-storchaka
serhiy-storchaka merged commit 4fabbf9 into python:3.13 Jun 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 22, 2024
@miss-islington
miss-islington deleted the backport-6ad26de-3.13 branch January 2, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.