GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi… by csabella · Pull Request #12101 · python/cpython

Conversation

@csabella

@csabella csabella commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

…mum_version (GH-11894).

(cherry picked from commit ae2ea33)

Co-authored-by: Zhiming Wang [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zmwangx @csabella
[3.7] Add versionadded directives to ssl.minimum_version and ssl.maxi…
08725bf 
…mum_version (pythonGH-11894).

(cherry picked from commit ae2ea33)

Co-authored-by: Zhiming Wang <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Feb 28, 2019
Add versionadded directives to ssl.minimum_version and ssl.maximum_version #11894
Merged
@bedevere-bot bedevere-bot added skip issue skip news docs Documentation in the Doc dir labels Feb 28, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 28, 2019
@bedevere-bot bedevere-bot added the awaiting merge label Feb 28, 2019
@csabella csabella added the 🤖 automerge label Feb 28, 2019
@miss-islington

miss-islington commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

@csabella: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 7dc322f into python:3.7 Feb 28, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 28, 2019
@csabella
csabella deleted the backport-ae2ea33-3.7 branch February 28, 2019 18:12
vstinner
vstinner reviewed Feb 28, 2019
View reviewed changes
Comment thread Doc/library/ssl.rst
Only available with OpenSSL 1.1.1 and TLS 1.3 enabled. Without TLS 1.3
support, the method raises :exc:`NotImplementedError`.

.. versionadded:: 3.7.1

@vstinner vstinner Feb 28, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum wait, why is it version 3.8 in the master branch but 3.7.1 in the 3.7 branch? The versionadded should be the same in 3.7 and master branches, no? cc @csabella @tiran (I only checked verify_client_post_handshake, I didn't check other versionadded markups.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@csabella csabella Feb 28, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it was when originally added in GH-9460 and GH-9505, so I didn't change it. If it should be 3.7.1 on both, I'll update master.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@csabella @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @zmwangx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.