GeezerVison is showing github.com — [3.13] gh-105623 Fix performance degradation in logging RotatingFileHandler (GH-105887) by miss-islington · Pull Request #121117 · python/cpython
Conversation
miss-islington
commented
Jun 28, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The check for whether the log file is a real file is expensive on NFS
filesystems. This commit reorders the rollover condition checking to
not do the file type check if the expected file size is less than the
rotation threshold.
(cherry picked from commit e9b4ec6)
Co-authored-by: Craig Robson [email protected]
Co-authored-by: Oleg Iarygin [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ndler (pythonGH-105887)
The check for whether the log file is a real file is expensive on NFS
filesystems. This commit reorders the rollover condition checking to
not do the file type check if the expected file size is less than the
rotation threshold.
(cherry picked from commit e9b4ec6)
Co-authored-by: Craig Robson <[email protected]>
Co-authored-by: Oleg Iarygin <[email protected]>
This was referenced Jun 28, 2024
Reviewers
vsajip
Awaiting requested review from vsajip
vsajip is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.