GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-120522: Add a `--with-app-store-compliance` configure option to patch out problematic code (GH-120984) by freakboy3742 · Pull Request #121174 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Jun 30, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

  • Add --app-store-compliance configuration option.

  • Added blurb.

  • Correct tab-vs-spaces formatting issue.

  • Correct source file name in docs.

  • Correct source code reference in Mac docs

  • Only apply the patch forward, and ensure the working directory is correct.

  • Make patching reslient to multiple builds.

  • Documentation fixes found during review

  • Documentation and configure.ac syntax improvements

  • Regenerate configure script.

  • Silence the patch echo output.

(cherry picked from commit 48cd104)

  • Issue: Python 3.12 change results in Apple App Store rejection #120522

📚 Documentation preview 📚: https://cpython-previews--121174.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742 @nineteendo
@ncoghlan @erlend-aasland
[3.12] pythongh-120522: Add a --with-app-store-compliance configure…
5252c49 
… option to patch out problematic code (pythonGH-120984)

* Add --app-store-compliance configuration option.

* Added blurb.

* Correct tab-vs-spaces formatting issue.

* Correct source file name in docs.

Co-authored-by: Nice Zombies <[email protected]>

* Correct source code reference in Mac docs

Co-authored-by: Nice Zombies <[email protected]>

* Only apply the patch forward, and ensure the working directory is correct.

* Make patching reslient to multiple builds.

* Documentation fixes found during review

Co-authored-by: Alyssa Coghlan <[email protected]>

* Documentation and configure.ac syntax improvements

Co-authored-by: Erlend E. Aasland <[email protected]>

* Regenerate configure script.

* Silence the patch echo output.

---------

(cherry picked from commit 48cd104)

Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@freakboy3742
freakboy3742 requested review from a team, corona10 and erlend-aasland as code owners June 30, 2024 00:59
This was referenced Jun 30, 2024
Python 3.12 change results in Apple App Store rejection #120522
Closed
gh-120522: Add a --with-app-store-compliance configure option to patch out problematic code #120984
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 30, 2024
@freakboy3742
freakboy3742 requested a review from Yhg1s June 30, 2024 01:00
@freakboy3742

freakboy3742 commented Jun 30, 2024

Copy link
Copy Markdown
Contributor Author

@Yhg1s Summary of context for this:

The underlying issue (the macOS App Store rejecting the Python 3.12 standard library) exists in 3.12; but this isn't a traditional bug fix - it's a built-in way to patch the issue if you're planning to submit to the macOS App Store. This requires adding a new configuration option (which could be considered a new feature). The underlying fix can be applied manually.

I've tagged you for review since it's your call as release manager call whether this is appropriate for backport. I'm completely happy if the answer is to close this backport as a WONTFIX.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 added the 3.12 only security fixes label Jun 30, 2024
@freakboy3742 freakboy3742 mentioned this pull request Jul 16, 2024
gh-120522: Apply App Store compliance patch to installed products, not source #121830
Closed
@freakboy3742

freakboy3742 commented Jul 16, 2024

Copy link
Copy Markdown
Contributor Author

I'm going to close this PR; the approach has been modified slightly; the new version to be backported is in #121830.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 closed this Jul 16, 2024
@freakboy3742
freakboy3742 deleted the backport-48cd104-3.12 branch July 30, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.