GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-119169: Speed up `os.fwalk(topdown=False)` by barneygale · Pull Request #121433 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jul 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add entries to the stack while iterating over os.scandir() results, rather than afterwards. This removes the need for an entries list and some zipping.

Requires #119473.

  • Issue: Improve performance of os.walk() #119169

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-119169: Speed up os.fwalk(topdown=False)
bedf76e 
Add entries to the stack while iterating over `os.scandir()` results,
rather than afterwards. This removes the need for an `entries` list and
some zipping.
@barneygale barneygale added the performance Performance or resource usage label Jul 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 6, 2024
Improve performance of os.walk() #119169
Open
@barneygale
Extraneous comment.
5325507
@barneygale barneygale mentioned this pull request Jul 8, 2024
GH-119169: Skip reversing sibling directories in os.[f]walk(topdown=False) #119473
Closed
@barneygale

barneygale commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

Closing because reversing sibling traversal order isn't kosher - see discussion on #119473.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.