GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. by Zheaoli · Pull Request #121550 · python/cpython

Conversation

@Zheaoli

@Zheaoli Zheaoli commented Jul 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix #121528

  • Issue: [3.13] _PyObject_Init() assertion fails with the stable ABI on Python built with assertions (extension built with Python 3.11) #121528

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Zheaoli added 2 commits July 10, 2024 03:09
@Zheaoli
gh121528: Fix the process crash when load extension when it's compile…
871d9e6 
…d with low version of the python
@Zheaoli
add news
faff2d4
@bedevere-app bedevere-app Bot added the awaiting review label Jul 9, 2024
@Zheaoli Zheaoli changed the title gh121528: Fix the process crash when load extension when it's compiled with low version of the python. gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. Jul 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 9, 2024
[3.13] _PyObject_Init() assertion fails with the stable ABI on Python built with assertions (extension built with Python 3.11) #121528
Closed
ZeroIntensity
ZeroIntensity requested changes Jul 9, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this PR fixes #121528

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jul 9, 2024
@ZeroIntensity

ZeroIntensity commented Jul 9, 2024

Copy link
Copy Markdown
Member

@Eclips4 Can you add the 3.13 backport label?
Zheaoli reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label Jul 10, 2024
@Eclips4

Eclips4 commented Jul 10, 2024

Copy link
Copy Markdown
Member

cc @mgorny can you confirm that this patch fixes the issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mgorny

mgorny commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

I can confirm that rustworkx no longer crashes with this patch applied.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Zheaoli
format code
6c8c823
ZeroIntensity
ZeroIntensity requested changes Jul 10, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issue-121528._Bo7rw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issue-121528._Bo7rw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Zheaoli and others added 2 commits July 10, 2024 20:10
@Zheaoli @ZeroIntensity
Update Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issu…
194a0e0 
…e-121528._Bo7rw.rst

Co-authored-by: Peter Bierma <[email protected]>
@Zheaoli @ZeroIntensity
Update Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issu…
74478b9 
…e-121528._Bo7rw.rst

Co-authored-by: Peter Bierma <[email protected]>
@Zheaoli

Zheaoli commented Jul 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity Thanks for the nits!
ZeroIntensity reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity
ZeroIntensity approved these changes Jul 10, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zheaoli Zheaoli closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.13 only security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[3.13] _PyObject_Init() assertion fails with the stable ABI on Python built with assertions (extension built with Python 3.11)

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Zheaoli @ZeroIntensity @Eclips4 @mgorny
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.