GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-82419: improve doc for ENABLE_USER_SITE by damngamerz · Pull Request #121684 · python/cpython

Conversation

@damngamerz

@damngamerz damngamerz commented Jul 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • improve doc according to the issue.

Not sure if did it correctly. My suggestion would be to just deprecate the whole ENABLE_USER_SITE configuration.

  • Issue: site.py reporting user site info even if ENABLE_USER_SITE=False #82419

📚 Documentation preview 📚: https://cpython-previews--121684.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@damngamerz
fix: improve doc for ENABLE_USER_SITE
7ec514e
@ghost

ghost commented Jul 13, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 13, 2024
site.py reporting user site info even if ENABLE_USER_SITE=False #82419
Open
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jul 13, 2024
@encukou

encukou commented Jul 13, 2024

Copy link
Copy Markdown
Member

AFAIK, changing site.py file won't work (unless you recompile Python), but administrators should still be able to set site.ENABLE_USER_SITE in a sitecustomize module.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Aug 1, 2024

Copy link
Copy Markdown
Member

Thanks for the contribution, but as it is, the addition is misleading.
I'll close this PR. Feel free to discuss on the issue, and open a new PR when ready.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@damngamerz @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.