GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109523: In _io_TextIOWrapper_read_impl skip decoding if bytes are None by giosiragusa · Pull Request #121739 · python/cpython

Conversation

@giosiragusa

@giosiragusa giosiragusa commented Jul 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: sys.stdin.read() throws a TypeError when stdin is set to be non-blocking #109523

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost

ghost commented Jul 14, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 14, 2024
sys.stdin.read() throws a TypeError when stdin is set to be non-blocking #109523
Closed
@bedevere-app

bedevere-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@giosiragusa
giosiragusa force-pushed the main branch from d03fda7 to 2aa975a Compare July 14, 2024 08:42
@bedevere-app

bedevere-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@giosiragusa
giosiragusa force-pushed the main branch from 53ec6c1 to 6fec029 Compare July 14, 2024 09:50
@bedevere-app

bedevere-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@bedevere-app

bedevere-app Bot commented Jul 14, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Aug 1, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-07-14-09-56-14.gh-issue-109523.lj6dfp.rst Outdated
@@ -0,0 +1 @@
stdin.read() no longer throws a TypeError if no input is provided when stdin is set to non-blocking.

@picnixz picnixz Aug 1, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdin.read() no longer throws a TypeError if no input is provided when stdin is set to non-blocking.
``sys.stdin.read()`` no longer throws a :exc:`TypeError` if no input is provided
when :data:`sys.stdin` is set to non-blocking.

I'm wondering whether the change should only mention sys.stdin or not. Here, it's for any TextIOWrapper.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@giosiragusa giosiragusa closed this Aug 12, 2024
@giosiragusa
giosiragusa force-pushed the main branch from 01e9f70 to 253c6a0 Compare August 12, 2024 07:10
@bedevere-app

bedevere-app Bot commented Aug 12, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@giosiragusa

giosiragusa commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

I'm closing this PR because was decide to return BlockingIOError instead than None
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@giosiragusa @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.