GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119698: deprecate ``symtable.Class.get_methods`` by picnixz · Pull Request #121902 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jul 17, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Deprecation notice for symtable.Class.get_methods for 3.14+ (to be merged after #121802 since it is included in this PR).

  • Issue: symtable.Class.get_methods() returns non-methods #119698

📚 Documentation preview 📚: https://cpython-previews--121902.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 10 commits July 15, 2024 19:19
@picnixz
fix symtable.Class.get_methods() (again)
e5f0f45
@picnixz
address review
9adbb27
@picnixz
update docs
e9d00c0
@picnixz
remove unused imports
0981fcf
@picnixz
fix doctest?
89eb370
@picnixz
add deprecation notice
0781ccd
@picnixz
configure doctest correctly?
e1402f2
@picnixz
remove deprecation notice for a separate PR
8a06e53
@picnixz
deprecate symtable.Class.get_methods
8006e31
@picnixz
blurb
667fd0f
@picnixz picnixz added the DO-NOT-MERGE label Jul 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 17, 2024
symtable.Class.get_methods() returns non-methods #119698
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 17, 2024
@picnixz
Merge remote-tracking branch 'upstream/main' into deprecate-get-metho…
c019696 
…ds-again
@picnixz picnixz removed the DO-NOT-MERGE label Jul 17, 2024
ZeroIntensity
ZeroIntensity reviewed Jul 17, 2024
View reviewed changes
Comment thread Lib/symtable.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ZeroIntensity
ZeroIntensity approved these changes Jul 17, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not too sure about the import warnings in the method body instead of at the module level. I'll let a core dev decide on that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jul 17, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Jul 17, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 17, 2024
@picnixz

picnixz commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

Friendly ping @JelleZijlstra in case you forgot about this one (or maybe if you were not aware of it).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Jul 22, 2024
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hadn't seen this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
JelleZijlstra merged commit c09d4c4 into python:main Jul 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 22, 2024
@picnixz
picnixz deleted the deprecate-get-methods-again branch July 22, 2024 14:24
@hugovk hugovk mentioned this pull request Jul 24, 2024
gh-122085: Use include files for whatsnew/3.14.rst deprecations #122242
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@picnixz @JelleZijlstra @serhiy-storchaka @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.