GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-119698: fix a special case in `symtable.Class.get_methods` (GH-121802) by miss-islington · Pull Request #121910 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 6682d91)

Co-authored-by: Bénédikt Tran [email protected]

  • Issue: symtable.Class.get_methods() returns non-methods #119698

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz @miss-islington
pythongh-119698: fix a special case in symtable.Class.get_methods (p…
0febef0 
…ythonGH-121802)

(cherry picked from commit 6682d91)

Co-authored-by: Bénédikt Tran <[email protected]>
This was referenced Jul 17, 2024
symtable.Class.get_methods() returns non-methods #119698
Closed
gh-119698: fix a special case in symtable.Class.get_methods #121802
Merged
@bedevere-app bedevere-app Bot added skip news awaiting review labels Jul 17, 2024
@JelleZijlstra JelleZijlstra self-assigned this Jul 17, 2024
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) July 17, 2024 13:29
@picnixz

picnixz commented Jul 17, 2024

Copy link
Copy Markdown
Member

Oh:

    type x[genexpr = (x async for x in [])] = (x async for x in [])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid syntax. Maybe you meant '==' or ':=' instead of '='?

Is it expected? did something change between 3.12 and 3.13 for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Jul 17, 2024

Copy link
Copy Markdown
Member

Oh yeah, I made comprehensions in annotation scopes a syntax error in 3.12, but then added support in 3.13.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Fix tests
b41ae05
@JelleZijlstra

JelleZijlstra commented Jul 17, 2024

Copy link
Copy Markdown
Member

And also, the tests were using TypeVar defaults, which only exist in 3.13. I removed the tests that rely on comprehensions within annotation scopes within classes, because that was a SyntaxError in 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 3279a4f into python:3.12 Jul 17, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 17, 2024
@miss-islington
miss-islington deleted the backport-6682d91-3.12 branch January 2, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @picnixz @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.