GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112301: `-fstack-protector-strong` is also needed in `LDFLAGS` on Solaris/Illumos by kulikjak · Pull Request #121979 · python/cpython

Conversation

@kulikjak

@kulikjak kulikjak commented Jul 18, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Linker on Solaris/Illumos is unhappy when you pass -fstack-protector-strong flag via CFLAGS but not LDFLAGS, resulting in the following failure after #120975:

Undefined			first referenced
 symbol  			    in file
__stack_chk_fail                    Programs/_freeze_module.o
__stack_chk_guard                   Programs/_freeze_module.o
ld: fatal: symbol referencing errors

I don't think that other links will mind, but I can certainly make this into a Solaris/Illumos specific LDFLAGS append.

  • Issue: Consider applying flags for warnings about potential security issues #112301

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kulikjak
kulikjak requested review from corona10 and erlend-aasland as code owners July 18, 2024 17:09
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2024
Consider applying flags for warnings about potential security issues #112301
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 18, 2024
@corona10

corona10 commented Jul 19, 2024

Copy link
Copy Markdown
Member

see: #121996 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request Jul 19, 2024
Introduce configure --disable-openssf-guide or --enable-openssf-guide #121996
Closed
@kulikjak
kulikjak force-pushed the Solaris-fstack-protector-fix branch from 16c3d48 to 5673fe7 Compare July 23, 2024 07:00
kulikjak added 2 commits July 30, 2024 15:01
@kulikjak
Solaris linker needs -fstack-protector-strong flags as well
cdfdb83
@kulikjak
regenerate configure
cd9638a
@kulikjak
kulikjak force-pushed the Solaris-fstack-protector-fix branch from 5673fe7 to cd9638a Compare July 30, 2024 13:05
@erlend-aasland
Merge branch 'main' into Solaris-fstack-protector-fix
0e89012
@erlend-aasland erlend-aasland added the skip news label Oct 14, 2024
@vstinner

vstinner commented Mar 26, 2026

Copy link
Copy Markdown
Member

I close this PR since it's inactive since July 2024: #112301 (comment). If you are still hitting the issue, I suggest opening a new PR. By the way, I'm not sure that modifying LDFLAGS is correct. Modifying LDFLAGS_NODIST sounds safer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kulikjak @corona10 @vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.