GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c (GH-121493) by miss-islington · Pull Request #122095 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

compare_unicode_generic(), compare_unicode_unicode() and
compare_generic() are callbacks used by do_lookup(). When enabling
assertions, it's not possible to inline these functions.
(cherry picked from commit c5a6b9a)

Co-authored-by: Victor Stinner [email protected]

  • Issue: always_inline makes build fail with -Og and --without-pydebug #121266

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner @miss-islington
pythongh-121266: Remove Py_ALWAYS_INLINE in dictobject.c (pythonGH-12…
ad75156
…1493)

compare_unicode_generic(), compare_unicode_unicode() and
compare_generic() are callbacks used by do_lookup(). When enabling
assertions, it's not possible to inline these functions.
(cherry picked from commit c5a6b9a)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington
miss-islington requested review from markshannon and methane as code owners July 21, 2024 16:47
@bedevere-app bedevere-app Bot mentioned this pull request Jul 21, 2024
always_inline makes build fail with -Og and --without-pydebug #121266
Closed
@bedevere-app bedevere-app Bot added the skip news label Jul 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 21, 2024
gh-121266: Remove Py_ALWAYS_INLINE in dictobject.c #121493
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Jul 21, 2024
@vstinner
vstinner enabled auto-merge (squash) July 21, 2024 16:47
@vstinner
vstinner merged commit e458268 into python:3.13 Jul 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 21, 2024
@miss-islington
miss-islington deleted the backport-c5a6b9a-3.13 branch January 2, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.