GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122087: Add tests for ismethoddescriptor() and isroutine() with partial objects by serhiy-storchaka · Pull Request #122219 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: 3.13.0b3: undocumented change in inspect.isroutine() for functools.partial #122087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-122087: Add tests for ismethoddescriptor() and isroutine() w…
f10bf09 
…ith partial objects
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Jul 24, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 24, 2024
3.13.0b3: undocumented change in inspect.isroutine() for functools.partial #122087
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 24, 2024
@serhiy-storchaka
serhiy-storchaka merged commit bb10858 into python:main Jul 25, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 25, 2024
@serhiy-storchaka
serhiy-storchaka deleted the partial-ismethoddescriptor-tests branch July 25, 2024 07:12
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Jul 25, 2024
@miss-islington-app

miss-islington-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 25, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bb108580dec5d8655ccdfb6c8737b5f64e3366d0 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Jul 25, 2024
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 only security fixes label Jul 25, 2024
@zuo zuo mentioned this pull request Aug 3, 2024
gh-122102: Improve tests for descriptor-related tools in inspect #122144
Open
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.