GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-121489: Export private _PyBytes_Join() again by cdce8p · Pull Request #122266 · python/cpython

Conversation

@cdce8p

@cdce8p cdce8p commented Jul 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Followup from #121489 and #121646 (comment). Export the _PyBytes_Join() again until the new public PyBytes_Join() is added. If backported to 3.13, this would make transitioning easier.

This partially reverts #107144.

/CC @vstinner

  • Issue: [C API] Private functions used by mypyc #121489

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cdce8p and others added 2 commits July 25, 2024 11:06
@cdce8p
[3.13] pythongh-121489: Export private _PyBytes_Join() again
f15bedf
@cdce8p @encukou
Code review
d76601d 
Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Jul 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2024
[C API] Private functions used by mypyc #121489
Closed
@cdce8p cdce8p closed this Jul 25, 2024
@cdce8p
cdce8p deleted the export-pybytes-join-3.13 branch July 25, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@cdce8p
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.