GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35967 resolve platform.processor late by jaraco · Pull Request #12239 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Mar 8, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue35967

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jaraco added 9 commits March 7, 2019 21:31
@jaraco
Replace flag-flip indirection with direct inspection
e2678d9
@jaraco
Use any for simpler code
5d93954
@jaraco
Avoid flag flip and set results directly.
df39881
@jaraco
Resolve processor in a single function.
da9976a
@jaraco
Extract processor handling into a namespace (class)
ba99fb5
@jaraco
Remove _syscmd_uname, unused
1385129
@jaraco
Restore platform.processor behavior to match prior expectation (relia…
9a628c4 
…nt on uname -p in a subprocess).
@jaraco
Extract '_unknown_as_blank' function.
3977f63
@jaraco
Override uname_result to resolve the processor late.
acd024e
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 8, 2019
@bedevere-bot bedevere-bot added the awaiting merge label Mar 8, 2019
jaraco and others added 6 commits April 13, 2019 21:14
@jaraco
Add a test intended to capture the expected values from 'uname -p'
9aacda9
@jaraco
Instead of trying to keep track of all of the possible outputs on dif…
aa29701 
…ferent systems (probably a fool's errand), simply assert that except for the known platform variance, uname().processor matches the output of 'uname -p'
@jaraco
Use a skipIf directive
01ac684
@jaraco
Use contextlib.suppress to suppress the error. Inline strip call.
9df8602
@jaraco
Merge branch 'feature/35967-uname-processor-baseline-tests' into feat…
793ddce 
…ure/35967-platform-processor-resolved-late
@blurb-it
📜🤖 Added by blurb_it.
ef4662d
@jaraco

jaraco commented Apr 14, 2019

Copy link
Copy Markdown
Member Author

I see the appveyor tests failed, but I'm going to assume that's a spurious failure, since it doesn't happen on the Azure pipelines and doesn't seem to be relevant to the test_platform tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella
csabella requested a review from malemburg June 1, 2019 15:15
@gpshead

gpshead commented Sep 12, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

reopening to retrigger CI. (we removed appveyor recently)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead closed this Sep 12, 2019
@gpshead gpshead reopened this Sep 12, 2019
@jaraco

jaraco commented Oct 27, 2019

Copy link
Copy Markdown
Member Author

In the aforementioned issue, Marc agreed this approach is suitable as long as it has tests, which it does. Is anything more needed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jaraco added 2 commits April 15, 2020 14:41
@jaraco
Merge branch 'master' into feature/35967-platform-processor-resolved-…
77dabaf 
…late
@jaraco
Merge branch 'master' into feature/35967-platform-processor-resolved-…
f0daf49 
…late
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@bedevere-bot

bedevere-bot commented Apr 16, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @jaraco for commit f0daf49 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@jaraco
Remove use of contextlib.suppress (it would fail with NameError if it…
d57e3ab 
… had any effect). Rely on _unknown_as_blank to replace unknown with blank.
@jaraco
jaraco removed the request for review from malemburg April 16, 2020 00:39
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@bedevere-bot

bedevere-bot commented Apr 16, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @jaraco for commit d57e3ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@jaraco

jaraco commented Apr 16, 2020

Copy link
Copy Markdown
Member Author

Failed checks look unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco closed this Apr 16, 2020
@jaraco jaraco reopened this Apr 16, 2020
@jaraco
jaraco merged commit 518835f into python:master Apr 16, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 16, 2020
@jaraco
jaraco deleted the feature/35967-platform-processor-resolved-late branch April 16, 2020 12:28
@tucked tucked mentioned this pull request May 8, 2020
bpo-40570: Count the processor property in len(platform.uname()) #20009
Closed
@methane methane mentioned this pull request Aug 5, 2021
platform: Import subprocess in function. #27610
Merged
@takluyver takluyver mentioned this pull request Sep 8, 2021
Get processor architecture at compile time h5py/h5py#1691
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jaraco @gpshead @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.