GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122234: Add DECREFs to error paths by encukou · Pull Request #122406 · python/cpython

Conversation

@encukou

@encukou encukou commented Jul 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Accuracy issues of sum() specialization for floats/complexes #122234

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-122234: Add DECREFs to error paths
a51d251
@encukou encukou added the skip news label Jul 29, 2024
@encukou
encukou requested a review from ericsnowcurrently as a code owner July 29, 2024 15:45
@bedevere-app bedevere-app Bot mentioned this pull request Jul 29, 2024
Accuracy issues of sum() specialization for floats/complexes #122234
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 29, 2024
@encukou

encukou commented Jul 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@Eclips4 sent the same PR at the same time: #122405

Please add

Co-Authored-By: Kirill Podoprigora <[email protected]>

when merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4
Eclips4 approved these changes Jul 29, 2024
View reviewed changes
@encukou
encukou enabled auto-merge (squash) July 29, 2024 15:51
@encukou
encukou merged commit 89fa05f into python:main Jul 29, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 29, 2024
@encukou
encukou deleted the sumleak branch July 29, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.