GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122399: change webbrowser.rst to better describe the contents of controller object by jordibc · Pull Request #122410 · python/cpython

Conversation

@jordibc

@jordibc jordibc commented Jul 29, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a minor change that addresses #122399 (for the 3.12 branch).

It fixes the reference to the attribute name so it belongs to the controller object (and not to the webbrowser module).

It also mentions that the controller object has a name attribute too, before mentioning it with the other methods.

  • Issue: Minor error in the doc for controller.name in the webbrowser documentation page #122399

📚 Documentation preview 📚: https://cpython-previews--122410.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jordibc
pythongh-122399: change webbrowser.rst to better describe the conten…
af52ff7
…ts of controller object

This is a minor change that addresses python#122399 (for the 3.12 branch).

It fixes the reference to the attribute `name` so it belongs to the controller object (and not to the webbrowser module).

It also mentions that the controller object has a name attribute too, before mentioning it with the other methods.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 29, 2024
Minor error in the doc for controller.name in the webbrowser documentation page #122399
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jul 29, 2024
@AA-Turner

AA-Turner commented Jul 29, 2024

Copy link
Copy Markdown
Member

We can address this in backports, we don't do direct PRs to branches.

See https://devguide.python.org/getting-started/pull-request-lifecycle/

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner closed this Jul 29, 2024
@jordibc

jordibc commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

Great, thanks @AA-Turner !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jordibc @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.