GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-82378: fix sys.tracebacklimit in pyrepl by cfbolz · Pull Request #122452 · python/cpython

Conversation

@cfbolz

@cfbolz cfbolz commented Jul 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

make sure that pyrepl uses the same logic for sys.tracebacklimit as both the basic repl and the standard sys.excepthook. as discussed on #82378, sys.tracebacklimit has two different meanings, and this pr makes sure that it's consistent in the two repls.

  • Issue: Meaning of tracebacklimit differs between sys.tracebacklimit and traceback module #82378

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cfbolz
pythongh-82378: fix sys.tracebacklimit in pyrepl
1d4f321 
make sure that pyrepl uses the same logic for sys.tracebacklimit as both
the basic repl and the standard sys.excepthook
@cfbolz
cfbolz requested review from ambv, lysnikolaou and pablogsal as code owners July 30, 2024 12:05
@bedevere-app bedevere-app Bot mentioned this pull request Jul 30, 2024
Meaning of tracebacklimit differs between sys.tracebacklimit and traceback module #82378
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 30, 2024
cfbolz added 2 commits July 31, 2024 14:48
@cfbolz
Merge branch 'main' into pythongh-82378-fix-tracebacklimit-in-pyrepl
01cb96a
@cfbolz
add news entry
2e18e4c
@cfbolz

cfbolz commented Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka would you maybe have time to look at this one as well? it's vaguely related to the excepthook PR: also a cornercase behaviour-change in pyrepl compared to the classic repl.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka self-requested a review July 31, 2024 14:28
@serhiy-storchaka

serhiy-storchaka commented Jul 31, 2024

Copy link
Copy Markdown
Member

I first want to merge #122528. It performs refactoring, so it will conflict with this PR, but at the end it can make it simpler.

I wonder how it affects this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz

cfbolz commented Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

I first want to merge #122528. It performs refactoring, so it will conflict with this PR, but at the end it can make it simpler.

I wonder how it affects this issue.

Thanks for the heads up, makes sense! I'm happy to rebase this pr once you're done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Aug 7, 2024

Copy link
Copy Markdown
Member

Please rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz

cfbolz commented Aug 9, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka I'm traveling for a bit, sorry, will do it end next week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz
Merge branch 'main' into pythongh-82378-fix-tracebacklimit-in-pyrepl
b741cb4
@cfbolz cfbolz mentioned this pull request Aug 16, 2024
gh-82378 fix sys.tracebacklimit in pyrepl #123062
Merged
@cfbolz

cfbolz commented Aug 16, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka I've merged main into the PR. you could look again.

I've also opened a variant of this PR, #123062 , with a more radical change. please pick whichever is more appropriate, I'm fine with either outcome.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Aug 16, 2024

Copy link
Copy Markdown
Member

#123062 looks better in long run. I propose to modify it (it can be considered a third variant).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz

cfbolz commented Aug 16, 2024

Copy link
Copy Markdown
Contributor Author

I'm closing this PR, #123062 looks much better now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cfbolz cfbolz closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cfbolz @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.