GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117657: Avoid race in `PAUSE_ADAPTIVE_COUNTER` in free-threaded build (GH-122190) by miss-islington · Pull Request #122475 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The adaptive counter doesn't do anything currently in the free-threaded
build and TSan reports a data race due to concurrent modifications to
the counter.
(cherry picked from commit 2b163aa)

Co-authored-by: Sam Gross [email protected]

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury @miss-islington
pythongh-117657: Avoid race in PAUSE_ADAPTIVE_COUNTER in free-threa…
029a164 
…ded build (pythonGH-122190)

The adaptive counter doesn't do anything currently in the free-threaded
build and TSan reports a data race due to concurrent modifications to
the counter.
(cherry picked from commit 2b163aa)

Co-authored-by: Sam Gross <[email protected]>
@miss-islington
miss-islington requested a review from markshannon as a code owner July 30, 2024 17:53
@bedevere-app bedevere-app Bot mentioned this pull request Jul 30, 2024
gh-117657: Avoid race in PAUSE_ADAPTIVE_COUNTER in free-threaded build #122190
Merged
@bedevere-app bedevere-app Bot added skip news topic-free-threading labels Jul 30, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jul 30, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jul 30, 2024
@colesbury
colesbury enabled auto-merge (squash) July 30, 2024 17:54
@colesbury
colesbury merged commit 8e96d85 into python:3.13 Jul 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 30, 2024
@miss-islington
miss-islington deleted the backport-2b163aa-3.13 branch January 2, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.