GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-120906: Support arbitrary hashable keys in FrameLocalsProxy (GH-122309) by encukou · Pull Request #122488 · python/cpython

Conversation

@encukou

@encukou encukou commented Jul 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Alyssa Coghlan [email protected]
(cherry picked from commit 5912487)

  • Issue: FrameLocalsProxy is stricter than dict about what constitutes a match #120906

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou @ncoghlan
[3.13] pythongh-120906: Support arbitrary hashable keys in FrameLocal…
a0ceae0
…sProxy (pythonGH-122309)

Co-authored-by: Alyssa Coghlan <[email protected]>
(cherry picked from commit 5912487)
@encukou
encukou requested a review from markshannon as a code owner July 30, 2024 22:42
This was referenced Jul 30, 2024
FrameLocalsProxy is stricter than dict about what constitutes a match #120906
Closed
gh-120906: Support arbitrary hashable keys in FrameLocalsProxy #122309
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 30, 2024
@encukou
encukou requested a review from gaogaotiantian July 30, 2024 22:42
gaogaotiantian
gaogaotiantian approved these changes Jul 31, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 31, 2024
@Yhg1s
Merge branch '3.13' into backport-5912487-3.13
0440af8
@Yhg1s
Yhg1s enabled auto-merge (squash) July 31, 2024 09:08
@Yhg1s
Yhg1s merged commit 8c8c43e into python:3.13 Jul 31, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @gaogaotiantian @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.