GeezerVison

The following commit authors need to sign the Contributor License Agreement:

• [email protected]

Click the button to sign:

I'm not a fan of returning None and emitting a warning instead of raising an error. That seems like a potential footgun; I could see developers being very confused as to why their code isn't working if they have warnings suppressed, or simply don't see them (e.g. they're buried in logs).

I'm not a fan of returning None and emitting a warning instead of raising an error. That seems like a potential footgun; I could see developers being very confused as to why their code isn't working if they have warnings suppressed, or simply don't see them (e.g. they're buried in logs).

Yes, what to do in the error case is certainly interesting. In my original implementation I returned [], but I can imagine a situation where the platform reports that there actually aren't any shared libraries (if you're in some MUSL, very static, environment, perhaps), so None seemed like a good distinction from [] and matched what ctypes.util.find_library() does

We certainly could let the error propagate, but there isn't much you can do as a user with the exceptions. Most use cases I can imagine would catch the error and then return something falsey, either None or [], and code that deals with this will need to handle that anyway.

We certainly could let the error propagate, but there isn't much you can do as a user with the exceptions. Most use cases I can imagine would catch the error and then return something falsey, either None or [], and code that deals with this will need to handle that anyway.

I think we should offload that choice to the user.

I am seeing that we're special-casing not having support for AIX. Does CPython even officially support AIX?

It's not listed in PEP 11, but there are ~150 other mentions of the platform in the codebase, mostly in test code, like the mentions here.

I'm not sure how long it takes to be reviewed and for the bot to update, but I wanted to note that my employer has filled out the CLA at this point

Bikeshedding: if we're going to allow returning None in some cases, we should name this something like find_libraries, for consistency with the None return of find_library.

All commit authors signed the Contributor License Agreement.

🤖 New build scheduled with the buildbot fleet by @encukou for commit 5ab1b02 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

🤖 New build scheduled with the buildbot fleet by @encukou for commit 80be2ab 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Android has libc.so, but not libffi.so :(

Android has libc.so, but not libffi.so :(

Android links ctypes against libffi statically. We could change this, but if it's only for this test, then it would be easier to just test for libc on Android instead.

Android has libc.so, but not libffi.so :(

Android links ctypes against libffi statically

I went ahead and updated the test to check if either libc.so or libffi.so is in the return on unix-alikes. Hopefully this guards against more platform issues, and we can always add a third candidate to this list if we end up with an even weirder platform that has neither...

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1c3594e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.